[turbofan] Turn JSToBoolean and JSUnaryNot into pure operators.

test/unittests/compiler/js-typed-lowering-unittest.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/access-builder.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/js-operator.h"
 #include "src/compiler/js-typed-lowering.h"
 #include "src/compiler/machine-operator.h"
 #include "src/compiler/node-properties-inl.h"
@@ skipping 60 matching lines @@
 
  private:
   JSOperatorBuilder javascript_;
 };
 
 
 // -----------------------------------------------------------------------------
 // JSToBoolean
 
 
+TEST_F(JSTypedLoweringTest, JSToBooleanWithBoolean) {
+  Node* input = Parameter(Type::Boolean());
+  Node* context = UndefinedConstant();
+
+  Reduction r =
+      Reduce(graph()->NewNode(javascript()->ToBoolean(), input, context));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_EQ(input, r.replacement());
+}
+
+
+TEST_F(JSTypedLoweringTest, JSToBooleanWithUndefined) {
+  Node* input = Parameter(Type::Undefined());
+  Node* context = UndefinedConstant();
+
+  Reduction r =
+      Reduce(graph()->NewNode(javascript()->ToBoolean(), input, context));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(), IsFalseConstant());
+}
+
+
+TEST_F(JSTypedLoweringTest, JSToBooleanWithNull) {
+  Node* input = Parameter(Type::Null());
+  Node* context = UndefinedConstant();
+
+  Reduction r =
+      Reduce(graph()->NewNode(javascript()->ToBoolean(), input, context));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(), IsFalseConstant());
+}
+
+
+TEST_F(JSTypedLoweringTest, JSToBooleanWithDetectableReceiver) {
+  Node* input = Parameter(Type::DetectableReceiver());
+  Node* context = UndefinedConstant();
+
+  Reduction r =
+      Reduce(graph()->NewNode(javascript()->ToBoolean(), input, context));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(), IsTrueConstant());
+}
+
+
+TEST_F(JSTypedLoweringTest, JSToBooleanWithUndetectable) {
+  Node* input = Parameter(Type::Undetectable());
+  Node* context = UndefinedConstant();
+
+  Reduction r =
+      Reduce(graph()->NewNode(javascript()->ToBoolean(), input, context));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(), IsFalseConstant());
+}
+
+
+TEST_F(JSTypedLoweringTest, JSToBooleanWithOrderedNumber) {
+  Node* input = Parameter(Type::OrderedNumber());
+  Node* context = UndefinedConstant();
+
+  Reduction r =
+      Reduce(graph()->NewNode(javascript()->ToBoolean(), input, context));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(),
+              IsBooleanNot(IsNumberEqual(input, IsNumberConstant(0))));
+}
+
+
 TEST_F(JSTypedLoweringTest, JSToBooleanWithString) {
   Node* input = Parameter(Type::String());
   Node* context = UndefinedConstant();
-  Node* effect = graph()->start();
-  Node* control = graph()->start();
 
-  Reduction r = Reduce(graph()->NewNode(javascript()->ToBoolean(), input,
-                                        context, effect, control));
+  Reduction r =
+      Reduce(graph()->NewNode(javascript()->ToBoolean(), input, context));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(),
               IsBooleanNot(IsNumberEqual(
                   IsLoadField(AccessBuilder::ForStringLength(), input,
                               graph()->start(), graph()->start()),
                   IsNumberConstant(0))));
 }
 
 
-TEST_F(JSTypedLoweringTest, JSToBooleanWithOrderedNumberAndBoolean) {
+TEST_F(JSTypedLoweringTest, JSToBooleanWithPhi) {
   Node* p0 = Parameter(Type::OrderedNumber(), 0);
   Node* p1 = Parameter(Type::Boolean(), 1);
   Node* context = UndefinedConstant();
-  Node* effect = graph()->start();
   Node* control = graph()->start();
 
   Reduction r = Reduce(graph()->NewNode(
       javascript()->ToBoolean(),
       graph()->NewNode(common()->Phi(kMachAnyTagged, 2), p0, p1, control),
-      context, effect, control));
+      context));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(
       r.replacement(),
       IsPhi(kMachAnyTagged,
             IsBooleanNot(IsNumberEqual(p0, IsNumberConstant(0))), p1, control));
 }
 
 
+TEST_F(JSTypedLoweringTest, JSToBooleanWithSelect) {
+  Node* p0 = Parameter(Type::Boolean(), 0);
+  Node* p1 = Parameter(Type::DetectableReceiver(), 1);
+  Node* p2 = Parameter(Type::OrderedNumber(), 2);
+  Node* context = UndefinedConstant();
+
+  Reduction r = Reduce(graph()->NewNode(
+      javascript()->ToBoolean(),
+      graph()->NewNode(common()->Select(kMachAnyTagged, BranchHint::kTrue), p0,
+                       p1, p2),
+      context));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(),
+              IsSelect(kMachAnyTagged, p0, IsTrueConstant(),
+                       IsBooleanNot(IsNumberEqual(p2, IsNumberConstant(0)))));
+}
+
+
 // -----------------------------------------------------------------------------
 // JSStrictEqual
 
 
 TEST_F(JSTypedLoweringTest, JSStrictEqualWithTheHole) {
   Node* const the_hole = HeapConstant(factory()->the_hole_value());
   Node* const context = UndefinedConstant();
   Node* const effect = graph()->start();
   Node* const control = graph()->start();
   TRACED_FOREACH(Type*, type, kJSTypes) {
@@ skipping 406 matching lines @@
           IsStoreElement(
               access, IsIntPtrConstant(bit_cast<intptr_t>(&backing_store[0])),
               key, value, effect, control));
     }
   }
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8