Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: chrome/chrome_common.gypi

Issue 792353002: Refactoring of Cast-related crypto code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes in response to comments by mfoltz Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_common.gypi
diff --git a/chrome/chrome_common.gypi b/chrome/chrome_common.gypi
index f7f3edacce12691be727ef1783ac332873f3ba93..721a6b2261c54d58b4f180583dd37203e98d0003 100644
--- a/chrome/chrome_common.gypi
+++ b/chrome/chrome_common.gypi
@@ -252,16 +252,23 @@
'common/service_process_util_win.cc',
],
'chrome_common_win_mac_sources': [
- 'common/extensions/api/networking_private/networking_private_crypto_nss.cc',
- 'common/extensions/api/networking_private/networking_private_crypto_openssl.cc',
- 'common/extensions/api/networking_private/networking_private_crypto.cc',
- 'common/extensions/api/networking_private/networking_private_crypto.h',
'common/media_galleries/itunes_library.cc',
'common/media_galleries/itunes_library.h',
'common/media_galleries/picasa_types.cc',
'common/media_galleries/picasa_types.h',
'common/media_galleries/pmp_constants.h',
],
+ 'chrome_common_networking_private_sources_openssl' : [
+ 'common/extensions/api/networking_private/networking_private_crypto_openssl.cc',
+ 'common/extensions/api/networking_private/networking_private_crypto.cc',
+ 'common/extensions/api/networking_private/networking_private_crypto.h',
+ ],
+ 'chrome_common_networking_private_sources_nss' : [
+ 'common/extensions/api/networking_private/networking_private_crypto_nss.cc',
+ 'common/extensions/api/networking_private/networking_private_crypto.cc',
+ 'common/extensions/api/networking_private/networking_private_crypto.h',
+ ],
+
'chrome_common_mac_sources': [
'common/media_galleries/iphoto_library.cc',
'common/media_galleries/iphoto_library.h',
@@ -343,12 +350,15 @@
['OS=="win" or OS=="mac"', {
'sources': [ '<@(chrome_common_win_mac_sources)' ],
}],
- ['(OS=="win" or OS=="mac") and use_openssl==1', {
- # networking_private_crypto_openssl.cc depends on boringssl.
+ ['(OS=="win" or OS=="mac" or chromeos==1) and use_openssl==1', {
+ 'sources': [ '<@(chrome_common_networking_private_sources_openssl)' ],
'dependencies': [
'../third_party/boringssl/boringssl.gyp:boringssl',
],
}],
+ ['(OS=="win" or OS=="mac" or chromeos==1) and use_openssl!=1', {
+ 'sources': [ '<@(chrome_common_networking_private_sources_nss)' ],
+ }],
['OS=="mac"', {
'sources': [ '<@(chrome_common_mac_sources)' ],
}],
@@ -497,17 +507,6 @@
['safe_browsing==2', {
'defines': [ 'MOBILE_SAFE_BROWSING' ],
}],
- ['use_openssl==1', {
- 'sources!': [
- 'common/extensions/api/networking_private/networking_private_crypto_nss.cc',
- ],
- },
- { # else !use_openssl
- 'sources!': [
- 'common/extensions/api/networking_private/networking_private_crypto_openssl.cc',
- ],
- },
- ],
],
'target_conditions': [
['OS == "ios"', {

Powered by Google App Engine
This is Rietveld 408576698