chrome/browser/extensions/api/networking_private/networking_private_verify_delegate_factory_impl.cc - Issue 792353002: Refactoring of Cast-related crypto code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_verify_delegate_factory_impl.cc

Issue 792353002: Refactoring of Cast-related crypto code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes in response to comments by mfoltz Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/networking_private/networking_private_verify_delegate_chromeos.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | extensions/common/cast/cast_cert_validator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/networking_private_verify_delegate_factory_impl.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_verify_delegate_factory_impl.cc b/chrome/browser/extensions/api/networking_private/networking_private_verify_delegate_factory_impl.cc

index 9ecc414192a7b2500b4ee5fd0a6138907f5dacbf..53f22c609a2f9ef8936e9dbc297775052e89c878 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_verify_delegate_factory_impl.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_verify_delegate_factory_impl.cc

@@ -4,11 +4,7 @@

#include "chrome/browser/extensions/api/networking_private/networking_private_verify_delegate_factory_impl.h"

-#if defined(OS_CHROMEOS)

-#include "chrome/browser/extensions/api/networking_private/networking_private_verify_delegate_chromeos.h"

-#elif defined(OS_WIN) || defined(OSMACOSX)

#include "chrome/browser/extensions/api/networking_private/crypto_verify_impl.h"

-#endif

namespace extensions {

@@ -22,9 +18,7 @@ NetworkingPrivateVerifyDelegateFactoryImpl::

scoped_ptr<NetworkingPrivateDelegate::VerifyDelegate>

NetworkingPrivateVerifyDelegateFactoryImpl::CreateDelegate() {

-#if defined(OS_CHROMEOS)

- return make_scoped_ptr(new NetworkingPrivateVerifyDelegateChromeOS());

-#elif defined(OS_WIN) || defined(OSMACOSX)

+#if defined(OS_CHROMEOS) || defined(OS_WIN) || defined(OSMACOSX)

mef 2015/01/05 17:24:08 I think stevenjb@ was doing some refactoring of th

sheretov 2015/01/05 22:43:03 Checked with stevenjb@. Linux-related changes wil

return make_scoped_ptr(new CryptoVerifyImpl());

#endif

return nullptr;