tools/chrome_proxy/integration_tests/network_metrics.py - Issue 792303006: Remove the net-internals dependency from chrome proxy telemetry tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/integration_tests/network_metrics.py

Issue 792303006: Remove the net-internals dependency from chrome proxy telemetry tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/reenable_after_bypass.py ('k') | tools/chrome_proxy/integration_tests/network_metrics_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_proxy/integration_tests/network_metrics.py

diff --git a/tools/chrome_proxy/integration_tests/network_metrics.py b/tools/chrome_proxy/integration_tests/network_metrics.py

index 59155c9316ff10b81b688787ef24b653a9b411aa..747d60dfb2a7a12f860db5b433682e0cbcbfd94e 100644

--- a/tools/chrome_proxy/integration_tests/network_metrics.py

+++ b/tools/chrome_proxy/integration_tests/network_metrics.py

@@ -26,6 +26,9 @@ class HTTPResponse(object):

def __init__(self, event):

self._response = (

inspector_network.InspectorNetworkResponseData.FromTimelineEvent(event))

+ self._remote_port = None

+ if 'response' in event.args and 'remotePort' in event.args['response']:

+ self._remote_port = event.args['response']['remotePort']

self._content_length = None

@property

@@ -33,6 +36,10 @@ class HTTPResponse(object):

return self._response

@property

+ def remote_port(self):

+ return self._remote_port

+ @property

def url_signature(self):

return hashlib.md5(self.response.url).hexdigest()