Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: tools/chrome_proxy/integration_tests/network_metrics_unittest.py

Issue 792303006: Remove the net-internals dependency from chrome proxy telemetry tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/chrome_proxy/integration_tests/network_metrics.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/chrome_proxy/integration_tests/network_metrics_unittest.py
diff --git a/tools/chrome_proxy/integration_tests/network_metrics_unittest.py b/tools/chrome_proxy/integration_tests/network_metrics_unittest.py
index 028bb2372f71d5570f53fd39ccd4748af7018203..8773c8e4fc186d271d38308742edee13de5d6265 100644
--- a/tools/chrome_proxy/integration_tests/network_metrics_unittest.py
+++ b/tools/chrome_proxy/integration_tests/network_metrics_unittest.py
@@ -27,7 +27,8 @@ class NetworkMetricTest(unittest.TestCase):
@staticmethod
def MakeNetworkTimelineEvent(
url, response_headers, body=None, base64_encoded_body=False,
- served_from_cache=False, request_headers=None, status=200):
+ served_from_cache=False, request_headers=None, status=200,
+ remote_port=None):
if not request_headers:
request_headers = {}
e = event.TimelineEvent('network', 'HTTPResponse', 0, 0)
@@ -38,6 +39,7 @@ class NetworkMetricTest(unittest.TestCase):
'url': url,
'headers': response_headers,
'requestHeaders': request_headers,
+ 'remotePort': remote_port,
}
e.args['body'] = body
e.args['base64_encoded_body'] = base64_encoded_body
« no previous file with comments | « tools/chrome_proxy/integration_tests/network_metrics.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698