webkit/glue/user_agent.h - Issue 7922023: Remove webkit_glue::BuildUserAgent(), remove windows spoofing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/glue/user_agent.h

Issue 7922023: Remove webkit_glue::BuildUserAgent(), remove windows spoofing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix GetUserAgent() to return whether the user agent is overriding, clean up Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/glue/user_agent.h

diff --git a/webkit/glue/user_agent.h b/webkit/glue/user_agent.h

index 583eef0a02db8a63d56074ec6a54198c01132e0c..8659dcfd046f3bb776dee3f9db2bf1f4c96a9baa 100644

--- a/webkit/glue/user_agent.h

+++ b/webkit/glue/user_agent.h

@@ -22,9 +22,7 @@ int GetWebKitMajorVersion();

int GetWebKitMinorVersion();

// Helper function to generate the user agent.

-// - If mimic_windows is true, produce a fake Windows Chrome string..

-std::string BuildUserAgentHelper(bool mimic_windows,

- const std::string& product);

+std::string BuildUserAgentHelper(const std::string& product);

Evan Martin 2011/09/21 20:27:24 It's not exactly your problem, but the word "Helpe

Dirk Pranke 2011/09/21 21:02:35 Agreed it's not a great name. I will attempt to fi

} // namespace webkit_glue

#endif // WEBKIT_GLUE_USER_AGENT_H_