Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webkit/glue/user_agent.cc

Issue 7922023: Remove webkit_glue::BuildUserAgent(), remove windows spoofing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix GetUserAgent() to return whether the user agent is overriding, clean up Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webkit/glue/user_agent.h ('K') | « webkit/glue/user_agent.h ('k') | webkit/glue/webkit_glue.h » ('j') | webkit/glue/webkit_glue.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/user_agent.cc
diff --git a/webkit/glue/user_agent.cc b/webkit/glue/user_agent.cc
index 7f9b43882e9f64f54a90e5be21f3776d7a9f66d7..73645f5ce3b498c40382266d4a54e82547aab1b6 100644
--- a/webkit/glue/user_agent.cc
+++ b/webkit/glue/user_agent.cc
@@ -113,8 +113,7 @@ int GetWebKitMinorVersion() {
return WEBKIT_VERSION_MINOR;
}
-std::string BuildUserAgentHelper(bool mimic_windows,
- const std::string& product) {
+std::string BuildUserAgentHelper(const std::string& product) {
const char kUserAgentPlatform[] =
#if defined(OS_WIN)
"";
@@ -137,7 +136,7 @@ std::string BuildUserAgentHelper(bool mimic_windows,
&user_agent,
"Mozilla/5.0 (%s%s) AppleWebKit/%d.%d"
" (KHTML, like Gecko) %s Safari/%d.%d",
- mimic_windows ? "Windows " : kUserAgentPlatform,
+ kUserAgentPlatform,
webkit_glue::BuildOSCpuInfo().c_str(),
WEBKIT_VERSION_MAJOR,
WEBKIT_VERSION_MINOR,
« webkit/glue/user_agent.h ('K') | « webkit/glue/user_agent.h ('k') | webkit/glue/webkit_glue.h » ('j') | webkit/glue/webkit_glue.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698