Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 792183003: Make changes to support bisect for android-chrome. (Closed)

Created:
6 years ago by prasadv
Modified:
6 years ago
Reviewers:
qyearsley, sh
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make changes to support bisect for android-chrome. BUG= NOTRY=true Committed: https://crrev.com/793b67d94e32c3e140d6eb230b07b406d17b673b Cr-Commit-Position: refs/heads/master@{#308002}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -28 lines) Patch
M tools/auto_bisect/bisect_perf_regression.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tools/auto_bisect/bisect_perf_regression_test.py View 1 1 chunk +8 lines, -0 lines 0 comments Download
M tools/auto_bisect/bisect_utils.py View 1 1 chunk +5 lines, -2 lines 0 comments Download
M tools/auto_bisect/source_control.py View 1 2 3 chunks +12 lines, -26 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
prasadv
6 years ago (2014-12-11 20:22:04 UTC) #2
qyearsley
lgtm https://codereview.chromium.org/792183003/diff/20001/tools/auto_bisect/source_control.py File tools/auto_bisect/source_control.py (right): https://codereview.chromium.org/792183003/diff/20001/tools/auto_bisect/source_control.py#newcode212 tools/auto_bisect/source_control.py:212: """Returns commit time for the given revision.""" This ...
6 years ago (2014-12-11 23:51:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792183003/40001
6 years ago (2014-12-12 00:09:16 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-12 00:11:08 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-12 00:12:47 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/793b67d94e32c3e140d6eb230b07b406d17b673b
Cr-Commit-Position: refs/heads/master@{#308002}

Powered by Google App Engine
This is Rietveld 408576698