tools/auto_bisect/bisect_perf_regression.py - Issue 792183003: Make changes to support bisect for android-chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/auto_bisect/bisect_perf_regression.py

Issue 792183003: Make changes to support bisect for android-chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/auto_bisect/bisect_perf_regression.py

diff --git a/tools/auto_bisect/bisect_perf_regression.py b/tools/auto_bisect/bisect_perf_regression.py

index bbea80cbb132432e7a6c1ae259377b6a8bac030d..9ad918924306f85c55c02a278a99ee0733ada635 100755

--- a/tools/auto_bisect/bisect_perf_regression.py

+++ b/tools/auto_bisect/bisect_perf_regression.py

@@ -1901,6 +1901,10 @@ class BisectPerformanceMetrics(object):

cwd = self.depot_registry.GetDepotDir(target_depot)

good_position = source_control.GetCommitPosition(good_revision, cwd)

bad_position = source_control.GetCommitPosition(bad_revision, cwd)

+ # Compare commit timestamp for repos that don't support commit position.

+ if not (bad_position and good_position):

+ good_position = source_control.GetCommitTime(good_revision, cwd=cwd)

+ bad_position = source_control.GetCommitTime(bad_revision, cwd=cwd)

return good_position <= bad_position

« no previous file with comments | « no previous file | tools/auto_bisect/bisect_perf_regression_test.py » ('j') | no next file with comments »