Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 792123002: Don't store an SkMatrix in BitmapShaderKey. (Closed)

Created:
6 years ago by f(malita)
Modified:
6 years ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Don't store an SkMatrix in BitmapShaderKey. SkMatrix makes for a poor key component due to mutable/cache fields. Use its canonical scalars instead. R=reed@google.com,mtklein@google.com Committed: https://skia.googlesource.com/skia/+/04b49c31789201fbef969f5598a286187920dd56

Patch Set 1 #

Patch Set 2 : use kMaxFlattenSize #

Total comments: 2

Patch Set 3 : moar explicit, less bzero #

Patch Set 4 : drop unneeded header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M src/core/SkPictureShader.cpp View 1 2 3 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
f(malita)
6 years ago (2014-12-10 19:22:14 UTC) #1
mtklein
https://codereview.chromium.org/792123002/diff/2/src/core/SkPictureShader.cpp File src/core/SkPictureShader.cpp (right): https://codereview.chromium.org/792123002/diff/2/src/core/SkPictureShader.cpp#newcode59 src/core/SkPictureShader.cpp:59: uint8_t fLocalMatrixStorage[SkMatrix::kMaxFlattenSize]; Let's be even more explicit? This actually ...
6 years ago (2014-12-10 19:52:47 UTC) #2
f(malita)
https://codereview.chromium.org/792123002/diff/2/src/core/SkPictureShader.cpp File src/core/SkPictureShader.cpp (right): https://codereview.chromium.org/792123002/diff/2/src/core/SkPictureShader.cpp#newcode59 src/core/SkPictureShader.cpp:59: uint8_t fLocalMatrixStorage[SkMatrix::kMaxFlattenSize]; On 2014/12/10 19:52:47, mtklein wrote: > Let's ...
6 years ago (2014-12-10 20:03:30 UTC) #3
mtklein
lgtm
6 years ago (2014-12-10 20:14:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792123002/50001
6 years ago (2014-12-10 20:56:28 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-10 21:01:48 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:50001) as
https://skia.googlesource.com/skia/+/04b49c31789201fbef969f5598a286187920dd56

Powered by Google App Engine
This is Rietveld 408576698