Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issue 792033004: Remove some unused/defunct about:flags strings. (Closed)

Created:
6 years ago by Evan Stade
Modified:
6 years ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some unused/defunct about:flags strings. IDS_FLAGS_DISAMBIGUATE_SERVER_NAME_TYPES removed here: https://codereview.chromium.org/796993002 IDS_FLAGS_ALTERNATE_SHELF_LAYOUT removed here: https://codereview.chromium.org/229453005 IDS_FLAGS_DISABLE_APP_LIST_VOICE_SEARCH removed here: https://codereview.chromium.org/353793003 IDS_FLAGS_DISABLE_LAYER_SQUASHING removed here: https://codereview.chromium.org/785323002 IDS_FLAGS_ENABLE_SPDY_PROXY_AUTH removed here: https://codereview.chromium.org/14398005/ BUG=none Committed: https://crrev.com/91beaa4ecd0d7e6e67d1142a4da95288cc741322 Cr-Commit-Position: refs/heads/master@{#309328}

Patch Set 1 #

Patch Set 2 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -31 lines) Patch
M chrome/app/generated_resources.grd View 6 chunks +1 line, -31 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Evan Stade
6 years ago (2014-12-20 01:57:59 UTC) #2
Lei Zhang
lgtm
6 years ago (2014-12-20 02:04:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792033004/20001
6 years ago (2014-12-20 02:05:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-20 03:27:18 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-20 03:28:49 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/91beaa4ecd0d7e6e67d1142a4da95288cc741322
Cr-Commit-Position: refs/heads/master@{#309328}

Powered by Google App Engine
This is Rietveld 408576698