Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 353793003: Remove disable-app-list-voice-search flag. (Closed)

Created:
6 years, 5 months ago by Jun Mukai
Modified:
6 years, 5 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Project:
chromium
Visibility:
Public.

Description

Remove disable-app-list-voice-search flag. BUG=367341 R=xiyuan@chromium.org TEST=compile Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281904

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/app_list/app_list_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/app_list_switches.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jun Mukai
6 years, 5 months ago (2014-07-07 22:12:52 UTC) #1
xiyuan
lgtm
6 years, 5 months ago (2014-07-07 23:02:43 UTC) #2
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 5 months ago (2014-07-08 20:39:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/353793003/1
6 years, 5 months ago (2014-07-08 20:41:51 UTC) #4
commit-bot: I haz the power
Change committed as 281904
6 years, 5 months ago (2014-07-09 00:25:12 UTC) #5
Yuta Kitamura
6 years, 5 months ago (2014-07-09 01:41:28 UTC) #6
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/379673003/ by yutak@chromium.org.

The reason for reverting is: Caused compile error on Blink GPU Mac Builder:
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder.

Powered by Google App Engine
This is Rietveld 408576698