Issue 792013002: Make some Selection function arguments non-optional

Issue 792013002: Make some Selection function arguments non-optional (Closed)

Created:
6 years ago by philipj_slow

Modified:
6 years ago

Reviewers:
yosin_UTC9

CC:
blink-reviews, arv+blink, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Make some Selection function arguments non-optional http://w3c.github.io/selection-api/#idl-def-Selection Firefox Nightly and IE11 both throw for the three tested cases, making this change very likely Web compatible. Some were left alone, pending a spec bug: https://github.com/w3c/selection-api/issues/30 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186929

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -7 lines)			Patch
A	LayoutTests/fast/dom/Selection/missing-arguments.html	View		1 chunk	+14 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/Selection/missing-arguments-expected.txt	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/DOMSelection.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/editing/Selection.idl	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 8 (2 generated)

yosin_UTC9

LGTM Thanks for clean up! Please be aware some web developer may file a bug ...

6 years ago (2014-12-11 01:44:28 UTC) #4

philipj_slow

Thanks for the review! This and many other CLs to make arguments non-optional do carry ...

6 years ago (2014-12-11 08:51:31 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792013002/20001

6 years ago (2014-12-11 08:52:28 UTC) #7

commit-bot: I haz the power

6 years ago (2014-12-11 09:43:37 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186929