Source/core/editing/DOMSelection.cpp - Issue 792013002: Make some Selection function arguments non-optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/DOMSelection.cpp

Issue 792013002: Make some Selection function arguments non-optional (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: update test Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/DOMSelection.cpp

diff --git a/Source/core/editing/DOMSelection.cpp b/Source/core/editing/DOMSelection.cpp

index 6a8a63ea9014d7162c73f7c3fced15217a6cb5e4..25703e256911f5e5673ad5af24a39089b115e0d4 100644

--- a/Source/core/editing/DOMSelection.cpp

+++ b/Source/core/editing/DOMSelection.cpp

@@ -493,8 +493,7 @@ bool DOMSelection::containsNode(const Node* n, bool allowPartial) const

void DOMSelection::selectAllChildren(Node* n, ExceptionState& exceptionState)

{

- if (!n)

- return;

+ ASSERT(n);

// This doesn't (and shouldn't) select text node characters.

setBaseAndExtent(n, 0, n, n->countChildren(), exceptionState);