Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: runtime/vm/assembler_mips_test.cc

Issue 791953003: Fix MIPS assembler test. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_mips_test.cc
===================================================================
--- runtime/vm/assembler_mips_test.cc (revision 42734)
+++ runtime/vm/assembler_mips_test.cc (working copy)
@@ -1643,9 +1643,11 @@
__ AddImmediate(SP, -8 * kWordSize);
regis 2015/01/09 17:16:02 Why 8*kWordSize? A double is 2*kWordSize, alignmen
__ LoadImmediate(T1, ~(8 - 1));
__ and_(T0, SP, T1); // Need 8 byte alignment.
+ __ AddImmediate(T0, T0, 2 * kWordSize);
regis 2015/01/09 17:16:02 This may work with 8*kWordSize above, but this is
__ LoadImmediate(D1, 1.0);
__ sdc1(D1, Address(T0));
__ ldc1(D0, Address(T0));
+ __ AddImmediate(SP, 8 * kWordSize);
regis 2015/01/09 17:16:02 3*kWordSize? It is only a test and efficiency is
zra 2015/01/09 17:49:28 Changed to something like this.
__ Ret();
}
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698