Issue 791763002: Revert of remove (dumb) canvas::NewRaster, and rename surface::NewRasterPMColor to N32Premul

Issue 791763002: Revert of remove (dumb) canvas::NewRaster, and rename surface::NewRasterPMColor to N32Premul (Closed)

Created:
6 years ago by reed1

Modified:
6 years ago

Reviewers:
f(malita), fmalita_google_do_not_use

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of remove (dumb) canvas::NewRaster, and rename surface::NewRasterPMColor to N32Premul (patchset #3 id:40001 of https://codereview.chromium.org/790733003/) Reason for revert: need to update chrome first Original issue's description: > remove (dumb) canvas::NewRaster, and rename surface::NewRasterPMColor to N32Premul > > patch from issue 781403002 at patchset 20001 (http://crrev.com/781403002#ps20001) > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/2c1605a1fbaa2e35a27399a34254fb1200ec2ae6 TBR=fmalita@google.com,fmalita@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/a8918a065075dece6e407cce0dfddf110e5d61a9

Created: 6 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+109 lines, -69 lines)			Patch
M	gm/fatpathfill.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/skia_for_chromium_defines.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	include/core/SkCanvas.h	View	1 chunk	+29 lines, -0 lines	0 comments	Download
M	include/core/SkSurface.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	samplecode/SamplePictFile.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/core/SkCanvas.cpp	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	tests/CanvasTest.cpp	View	4 chunks	+6 lines, -13 lines	0 comments	Download
M	tests/DeferredCanvasTest.cpp	View	8 chunks	+8 lines, -8 lines	0 comments	Download
M	tests/DrawBitmapRectTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/DrawPathTest.cpp	View	6 chunks	+31 lines, -29 lines	0 comments	Download
M	tests/PathTest.cpp	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/RecordDrawTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/RecorderTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/SkResourceCacheTest.cpp	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	tools/skhello.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

reed1

Created Revert of remove (dumb) canvas::NewRaster, and rename surface::NewRasterPMColor to N32Premul

6 years ago (2014-12-09 21:54:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791763002/1

6 years ago (2014-12-09 21:55:09 UTC) #2

commit-bot: I haz the power

6 years ago (2014-12-09 21:55:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a8918a065075dece6e407cce0dfddf110e5d61a9