Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 790733003: remove (dumb) canvas::NewRaster, and rename surface::NewRasterPMColor to N32Premul (Closed)

Created:
6 years ago by reed1
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

remove (dumb) canvas::NewRaster, and rename surface::NewRasterPMColor to N32Premul patch from issue 781403002 at patchset 20001 (http://crrev.com/781403002#ps20001) BUG=skia: Committed: https://skia.googlesource.com/skia/+/2c1605a1fbaa2e35a27399a34254fb1200ec2ae6

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : rebase after chrome patches have landed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -103 lines) Patch
M gm/fatpathfill.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkCanvas.h View 1 chunk +0 lines, -29 lines 0 comments Download
M include/core/SkSurface.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M samplecode/SamplePictFile.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M tests/CanvasTest.cpp View 4 chunks +13 lines, -6 lines 0 comments Download
M tests/DeferredCanvasTest.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M tests/DrawBitmapRectTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/DrawPathTest.cpp View 6 chunks +23 lines, -25 lines 0 comments Download
M tests/PathTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/RecordDrawTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RecorderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SkResourceCacheTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/skhello.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
reed1
6 years ago (2014-12-09 16:30:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790733003/40001
6 years ago (2014-12-09 20:20:37 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-09 20:20:38 UTC) #5
reed1
I will test it locally against mac chrome. ptal
6 years ago (2014-12-09 20:30:44 UTC) #6
f(malita)
lgtm https://codereview.chromium.org/790733003/diff/40001/samplecode/SamplePictFile.cpp File samplecode/SamplePictFile.cpp (left): https://codereview.chromium.org/790733003/diff/40001/samplecode/SamplePictFile.cpp#oldcode139 samplecode/SamplePictFile.cpp:139: if (false) { Leaving this in intentionally?
6 years ago (2014-12-09 20:33:18 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/2c1605a1fbaa2e35a27399a34254fb1200ec2ae6
6 years ago (2014-12-09 20:33:44 UTC) #9
reed1
6 years ago (2014-12-09 21:54:06 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/791763002/ by reed@google.com.

The reason for reverting is: need to update chrome first.

Powered by Google App Engine
This is Rietveld 408576698