Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 791743006: Fix WeakPtrFactory member ordering in device (Closed)

Created:
6 years ago by anujsharma
Modified:
6 years ago
CC:
chromium-reviews, dmichael (off chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WeakPtrFactory member ordering in device Changing in the intialization order of WeakPtrFactory such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/bead29c2ec344697c4938a2296b015a39f65a000 Cr-Commit-Position: refs/heads/master@{#308090}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M device/usb/usb_device_handle_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/usb_device_handle_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
anujsharma
PTAL
6 years ago (2014-12-11 09:52:52 UTC) #2
Ken Rockot(use gerrit already)
lgtm
6 years ago (2014-12-12 02:12:31 UTC) #3
anujsharma
On 2014/12/12 02:12:31, Ken Rockot wrote: > lgtm Thanks Ken Rockot for lgtm.
6 years ago (2014-12-12 02:48:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791743006/1
6 years ago (2014-12-12 02:50:04 UTC) #6
anujsharma
@Ken Rockot, I marked the commit but came to know Dmichael has also submitted almost ...
6 years ago (2014-12-12 02:57:49 UTC) #10
dmichael (off chromium)
It should be really easy for me to merge; we can land this one. I ...
6 years ago (2014-12-12 15:55:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791743006/1
6 years ago (2014-12-12 15:55:40 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 15:56:30 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-12 15:57:21 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bead29c2ec344697c4938a2296b015a39f65a000
Cr-Commit-Position: refs/heads/master@{#308090}

Powered by Google App Engine
This is Rietveld 408576698