Reland "Use same blob format for internal and external snapshots."

Reland "Use same blob format for internal and external snapshots."

[Yang, 2014-12-10 09:00:42]

Patchset #2 (id:20001) has been deleted

[Yang, 2014-12-10 09:27:31]

Please take a look. Patch set 2 contains the fix.

[Yang, 2014-12-10 09:29:27]

yangguo@chromium.org changed reviewers:
+ vogelheim@google.com

[vogelheim, 2014-12-10 11:41:57]

vogelheim@chromium.org changed reviewers:
+ vogelheim@chromium.org

[vogelheim, 2014-12-10 11:41:58]

https://codereview.chromium.org/791723004/diff/40001/src/snapshot-external.cc
File src/snapshot-external.cc (right):

https://codereview.chromium.org/791723004/diff/40001/src/snapshot-external.cc...
src/snapshot-external.cc:22: static v8::StartupData external_startup_blob =
{NULL, 0};
Hmm... does this count as a static initializer, which I hear we don't like very
much?

(Sorry for the vagueness, but actually I'm not entirely sure what V8's and/or
Chromium's rules on this are.)

[vogelheim, 2014-12-10 11:43:17]

lgtm

[Yang, 2014-12-10 11:44:32]

On 2014/12/10 11:43:17, vogelheim wrote:
> lgtm

As discussed, tools/check-static-initializers.sh is happy, so I think this is
fine.

[Yang, 2014-12-10 11:44:39]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2014-12-10 11:45:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/791723004/40001

[commit-bot: I haz the power, 2014-12-10 11:46:32]

Committed patchset #2 (id:40001)