BUILD.gn - Issue 791723004: Reland "Use same blob format for internal and external snapshots."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 791723004: Reland "Use same blob format for internal and external snapshots." (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index 5ba15f8d620ab67d0da0243774c98022ca6d19e8..0200dc013062933f6be7d402626b7d6e53c00eb8 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -357,7 +357,6 @@ source_set("v8_nosnapshot") {

"$target_gen_dir/libraries.cc",

"$target_gen_dir/experimental-libraries.cc",

"src/snapshot-empty.cc",

- "src/snapshot-common.cc",

]

configs -= [ "//build/config/compiler:chromium_code" ]

@@ -379,7 +378,6 @@ source_set("v8_snapshot") {

"$target_gen_dir/libraries.cc",

"$target_gen_dir/experimental-libraries.cc",

"$target_gen_dir/snapshot.cc",

- "src/snapshot-common.cc",

]

configs -= [ "//build/config/compiler:chromium_code" ]

@@ -894,6 +892,7 @@ source_set("v8_base") {

"src/serialize.h",

"src/small-pointer-list.h",

"src/smart-pointers.h",

+ "src/snapshot-common.cc",

"src/snapshot-source-sink.cc",

"src/snapshot-source-sink.h",

"src/snapshot.h",

« no previous file with comments | « no previous file | Makefile » ('j') | src/snapshot-external.cc » ('J')