Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issue 79143002: Revert 236254 "Replace old with new synthetic gesture framework." (Closed)

Created:
7 years, 1 month ago by Ryan Hamilton
Modified:
7 years, 1 month ago
Reviewers:
Dominik Grewe
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 236254 "Replace old with new synthetic gesture framework." > Replace old with new synthetic gesture framework. > > - Remove current implementation of synthetic gestures. > - Rename temporarily named classes and files of new synthetic gesture framework > (e.g. SyntheticGestureNew -> SyntheticGesture). > - Link up new implementation in browser and renderer. > - Hook up synthetic gesture controller to input flushing in RWHI. > - Update JavaScript front-end and Telemetry. > > BUG=297980 > > Review URL: https://codereview.chromium.org/62443007 TBR=dominikg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236264

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -1119 lines) Patch
M trunk/src/content/browser/android/content_view_core_impl.h View 1 chunk +11 lines, -0 lines 0 comments Download
M trunk/src/content/browser/android/content_view_core_impl.cc View 1 chunk +24 lines, -0 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/basic_mouse_wheel_smooth_scroll_gesture.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/basic_mouse_wheel_smooth_scroll_gesture.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/generic_touch_gesture_android.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/generic_touch_gesture_android.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/content/browser/renderer_host/input/immediate_input_router.cc View 1 chunk +3 lines, -1 line 0 comments Download
D trunk/src/content/browser/renderer_host/input/synthetic_gesture.h View 1 chunk +0 lines, -57 lines 0 comments Download
D trunk/src/content/browser/renderer_host/input/synthetic_gesture.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D trunk/src/content/browser/renderer_host/input/synthetic_gesture_controller.h View 1 chunk +0 lines, -49 lines 0 comments Download
D trunk/src/content/browser/renderer_host/input/synthetic_gesture_controller.cc View 1 chunk +0 lines, -80 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/input/synthetic_gesture_controller_new.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/input/synthetic_gesture_controller_new.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/input/synthetic_gesture_controller_new_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc View 1 chunk +0 lines, -432 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/input/synthetic_gesture_new.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/input/synthetic_gesture_new.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/content/browser/renderer_host/input/synthetic_gesture_target.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/input/synthetic_gesture_target_base.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/input/synthetic_gesture_target_base.cc View 3 chunks +1 line, -4 lines 0 comments Download
D trunk/src/content/browser/renderer_host/input/synthetic_pinch_gesture.h View 1 chunk +0 lines, -48 lines 0 comments Download
D trunk/src/content/browser/renderer_host/input/synthetic_pinch_gesture.cc View 1 chunk +0 lines, -109 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/input/synthetic_pinch_gesture_new.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/input/synthetic_pinch_gesture_new.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.h View 1 chunk +0 lines, -50 lines 0 comments Download
D trunk/src/content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.cc View 1 chunk +0 lines, -108 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/input/synthetic_smooth_scroll_gesture_new.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/input/synthetic_smooth_scroll_gesture_new.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_impl.h View 4 chunks +8 lines, -3 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_impl.cc View 8 chunks +18 lines, -22 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +6 lines, -0 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_android.cc View 3 chunks +26 lines, -0 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +5 lines, -0 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +6 lines, -0 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_base.cc View 2 chunks +17 lines, -0 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/synthetic_gesture_calculator.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/synthetic_gesture_calculator.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/synthetic_gesture_controller.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/synthetic_gesture_controller.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/synthetic_gesture_controller_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/touch_smooth_scroll_gesture_aura.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/touch_smooth_scroll_gesture_aura.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/content/common/input_messages.h View 3 chunks +0 lines, -6 lines 0 comments Download
M trunk/src/content/common/view_messages.h View 2 chunks +23 lines, -0 lines 0 comments Download
M trunk/src/content/content_browser.gypi View 6 chunks +19 lines, -8 lines 0 comments Download
M trunk/src/content/content_jni.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/content/content_tests.gypi View 2 chunks +2 lines, -1 line 0 comments Download
M trunk/src/content/port/browser/render_widget_host_view_port.h View 1 chunk +11 lines, -0 lines 0 comments Download
A + trunk/src/content/port/browser/synthetic_gesture.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +16 lines, -0 lines 0 comments Download
A + trunk/src/content/public/android/java/src/org/chromium/content/browser/GenericTouchGesture.java View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/content/renderer/gpu/gpu_benchmarking_extension.cc View 8 chunks +46 lines, -73 lines 0 comments Download
M trunk/src/content/renderer/render_widget.h View 3 chunks +22 lines, -11 lines 0 comments Download
M trunk/src/content/renderer/render_widget.cc View 6 chunks +39 lines, -20 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/page/actions/scroll.js View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/page/actions/scroll.py View 2 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ryan Hamilton
7 years, 1 month ago (2013-11-20 19:02:05 UTC) #1
Ryan Hamilton
Committed patchset #1 manually as r236264.
7 years, 1 month ago (2013-11-20 19:02:48 UTC) #2
Dominik Grewe
On 2013/11/20 19:02:48, Ryan Hamilton wrote: > Committed patchset #1 manually as r236264. Can you ...
7 years, 1 month ago (2013-11-20 19:20:02 UTC) #3
Ryan Hamilton
It's been a crazing morning :> Sorry for the headache. The XP bots are consistently ...
7 years, 1 month ago (2013-11-20 19:23:48 UTC) #4
Dominik Grewe
On 2013/11/20 19:23:48, Ryan Hamilton wrote: > It's been a crazing morning :> Sorry for ...
7 years, 1 month ago (2013-11-20 19:27:39 UTC) #5
Dominik Grewe
On 2013/11/20 19:27:39, Dominik Grewe wrote: > On 2013/11/20 19:23:48, Ryan Hamilton wrote: > > ...
7 years, 1 month ago (2013-11-21 11:22:32 UTC) #6
Ryan Hamilton
On 2013/11/21 11:22:32, Dominik Grewe wrote: > On 2013/11/20 19:27:39, Dominik Grewe wrote: > > ...
7 years, 1 month ago (2013-11-21 17:37:03 UTC) #7
Dominik Grewe
7 years, 1 month ago (2013-11-21 17:46:09 UTC) #8
Message was sent while issue was closed.
On 2013/11/21 17:37:03, Ryan Hamilton wrote:
> On 2013/11/21 11:22:32, Dominik Grewe wrote:
> > On 2013/11/20 19:27:39, Dominik Grewe wrote:
> > > On 2013/11/20 19:23:48, Ryan Hamilton wrote:
> > > > It's been a crazing morning :>  Sorry for the headache.  The XP bots are
> > > > consistently failing after this CL and two others landed.  After
reverting
> > > > the most likely culprit, the bots failed again so we reverted the other
> > > > two.  In the mean time, we've also enlisted the troopers in case this is
a
> > > > bot problem.  Totally sorry for the headache!  I hate it when my CLs get
> > > > reverted :>
> > > > 
> > > > If it turns out the be a bot problem, you can feel free to re-land.
> > > 
> > > Okay, no problem. Keep me updated :)
> > 
> > Any news on this? Did you figure out what caused the bots failing? Is there
a
> > bug I could follow to get updates?
> 
> Whoops, sorry for not following up.  It turned out not to be a bot issue,
rather
> it was one of the other CLs that landed when yours did.  Please feel free to
> reland.

Okay, thanks. I'll reland my CL.

Powered by Google App Engine
This is Rietveld 408576698