Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: trunk/src/tools/telemetry/telemetry/page/actions/scroll.py

Issue 79143002: Revert 236254 "Replace old with new synthetic gesture framework." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/tools/telemetry/telemetry/page/actions/scroll.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/tools/telemetry/telemetry/page/actions/scroll.py
===================================================================
--- trunk/src/tools/telemetry/telemetry/page/actions/scroll.py (revision 236262)
+++ trunk/src/tools/telemetry/telemetry/page/actions/scroll.py (working copy)
@@ -21,8 +21,6 @@
'Synthetic scroll not supported for this browser')
# Fail if this action requires touch and we can't send touch events.
- # TODO(dominikg): Query synthetic gesture target to check if touch is
- # supported.
if (hasattr(self, 'scroll_requires_touch') and
self.scroll_requires_touch and not
tab.EvaluateJavaScript(
@@ -48,32 +46,26 @@
# }
left_start_percentage = 0.5
top_start_percentage = 0.5
- gesture_source_type = 'chrome.gpuBenchmarking.DEFAULT_INPUT'
if hasattr(self, 'left_start_percentage'):
left_start_percentage = self.left_start_percentage
if hasattr(self, 'top_start_percentage'):
top_start_percentage = self.top_start_percentage
- if hasattr(self, 'scroll_requires_touch') and self.scroll_requires_touch:
- gesture_source_type = 'chrome.gpuBenchmarking.TOUCH_INPUT'
if hasattr(self, 'scrollable_element_function'):
tab.ExecuteJavaScript("""
(%s)(function(element) { window.__scrollAction.start(
{ element: element,
left_start_percentage: %s,
- top_start_percentage: %s,
- gesture_source_type: %s })
+ top_start_percentage: %s })
});""" % (self.scrollable_element_function,
left_start_percentage,
- top_start_percentage,
- gesture_source_type))
+ top_start_percentage))
else:
tab.ExecuteJavaScript("""
window.__scrollAction.start(
{ element: document.body,
left_start_percentage: %s,
- top_start_percentage: %s,
- gesture_source_type: %s });"""
- % (left_start_percentage, top_start_percentage, gesture_source_type))
+ top_start_percentage: %s });"""
+ % (left_start_percentage, top_start_percentage))
tab.WaitForJavaScriptExpression('window.__scrollActionDone', 60)
« no previous file with comments | « trunk/src/tools/telemetry/telemetry/page/actions/scroll.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698