Prevent Shift+Tab from locking up the browser when in the app list.

Prevent Shift+Tab from locking up the browser when in the app list.

This CL fixes an issue where Shift+Tab would lock up the whole chrome
browser process when in the app list. This has been fixed by explicitly
capturing the Shift+Tab event since there are no other focus targets
anyway.

BUG=438425
Committed: https://crrev.com/d11a464f773172ae955ff75e16f641e3349e8437
Cr-Commit-Position: refs/heads/master@{#308308}

[calamity, 2014-12-12 08:57:29]

calamity@chromium.org changed reviewers:
+ mgiuca@chromium.org

[Matt Giuca, 2014-12-14 22:40:30]

This feels a bit ad-hoc. If there were other controls that could have focus,
wouldn't this rule either a) not apply on those other elements (creating the
same problem), or b) break the shift-tab expected behaviour?

Still, it fixes the problem and we don't have a general solution in sight, so
lgtm.

https://codereview.chromium.org/791403004/diff/1/ui/app_list/views/search_box...
File ui/app_list/views/search_box_view.cc (right):

https://codereview.chromium.org/791403004/diff/1/ui/app_list/views/search_box...
ui/app_list/views/search_box_view.cc:224: if (key_event.key_code() ==
ui::VKEY_TAB && key_event.IsShiftDown())
Copy some text from the CL description to a comment here please.

[calamity, 2014-12-15 02:28:55]

Patchset #3 (id:40001) has been deleted

[calamity, 2014-12-15 02:31:39]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-12-15 02:31:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/791403004/20001

[calamity, 2014-12-15 02:37:12]

https://codereview.chromium.org/791403004/diff/1/ui/app_list/views/search_box...
File ui/app_list/views/search_box_view.cc (right):

https://codereview.chromium.org/791403004/diff/1/ui/app_list/views/search_box...
ui/app_list/views/search_box_view.cc:224: if (key_event.key_code() ==
ui::VKEY_TAB && key_event.IsShiftDown())
On 2014/12/14 22:40:30, Matt Giuca (OOO Dec20 -- Jan4) wrote:
> Copy some text from the CL description to a comment here please.

Done.

[commit-bot: I haz the power, 2014-12-15 03:25:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-15 03:25:54]

Patchset 2 (id:??) landed as
https://crrev.com/d11a464f773172ae955ff75e16f641e3349e8437
Cr-Commit-Position: refs/heads/master@{#308308}