Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: ui/app_list/views/search_box_view.cc

Issue 791403004: Prevent Shift+Tab from locking up the browser when in the app list. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@app_result_display_recommendation
Patch Set: add_comment Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/views/search_box_view.cc
diff --git a/ui/app_list/views/search_box_view.cc b/ui/app_list/views/search_box_view.cc
index a72414970c430a7812536963c4027a1b09208d4f..4126f0d79b8216f5b65ff801792a85bd460202bf 100644
--- a/ui/app_list/views/search_box_view.cc
+++ b/ui/app_list/views/search_box_view.cc
@@ -221,6 +221,13 @@ bool SearchBoxView::HandleKeyEvent(views::Textfield* sender,
if (contents_view_ && contents_view_->visible())
handled = contents_view_->OnKeyPressed(key_event);
+ // Prevent Shift+Tab from locking up the whole chrome browser process.
+ // Explicitly capturing the Shift+Tab event here compensates for a focus
+ // search issue. We get away with this because there are no other focus
+ // targets. See http://crbug.com/438425 for details.
+ if (key_event.key_code() == ui::VKEY_TAB && key_event.IsShiftDown())
+ handled = true;
+
return handled;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698