Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 791363002: Disable invalid DCHECK_EQ in serializer.cc (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)
Modified:
6 years ago
Reviewers:
mvstanton, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable invalid DCHECK_EQ in serializer.cc BUG=none R=mvstanton@chromium.org,yangguo@chromium.org LOG=n

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/serialize.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
6 years ago (2014-12-11 10:23:19 UTC) #1
Yang
On 2014/12/11 10:23:19, jochen (slow) wrote: lgtm
6 years ago (2014-12-11 10:48:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791363002/1
6 years ago (2014-12-11 10:56:12 UTC) #4
mvstanton
lgtm
6 years ago (2014-12-11 11:21:18 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-11 11:24:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698