Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Unified Diff: src/serialize.cc

Issue 791363002: Disable invalid DCHECK_EQ in serializer.cc (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/serialize.cc
diff --git a/src/serialize.cc b/src/serialize.cc
index 8222ff66d85cfb11cc542ff6c0b6e850303ccdff..ba7e168025d160b7e3f5060ebedda0d955762274 100644
--- a/src/serialize.cc
+++ b/src/serialize.cc
@@ -491,7 +491,9 @@ RootIndexMap::RootIndexMap(Isolate* isolate) {
if (LookupEntry(map_, heap_object, false) != NULL) {
// Some root values are initialized to the empty FixedArray();
// Do not add them to the map.
- DCHECK_EQ(isolate->heap()->empty_fixed_array(), heap_object);
+ // TODO(yangguo): This assert is not true. Some roots like
+ // instanceof_cache_answer can be e.g. null.
+ // DCHECK_EQ(isolate->heap()->empty_fixed_array(), heap_object);
} else {
SetValue(LookupEntry(map_, heap_object, true), i);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698