Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: dart/pkg/compiler/lib/src/scanner/listener.dart

Issue 791263003: Remove Compiler.reportFatalError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: One more crash revealed. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« dart/pkg/compiler/lib/src/resolution/signatures.dart ('K') | « dart/pkg/compiler/lib/src/resolution/signatures.dart ('k') | dart/pkg/compiler/lib/src/string_validator.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/pkg/compiler/lib/src/scanner/listener.dart
diff --git a/dart/pkg/compiler/lib/src/scanner/listener.dart b/dart/pkg/compiler/lib/src/scanner/listener.dart
index 887232e5ae15de41569f8a2f6861b1b74349f1cd..c997b1159d378b14238b02e6cedf30f3ad25c4a8 100644
--- a/dart/pkg/compiler/lib/src/scanner/listener.dart
+++ b/dart/pkg/compiler/lib/src/scanner/listener.dart
@@ -1465,8 +1465,9 @@ class ElementListener extends Listener {
void reportFatalError(Spannable spannable,
Johnni Winther 2015/01/06 08:12:05 Maybe deprecate this method.
ahe 2015/01/07 12:55:24 I don't think this should be deprecated, there are
String message) {
- listener.reportFatalError(
+ listener.reportError(
spannable, MessageKind.GENERIC, {'text': message});
+ throw new CompilerCancelledException(message);
}
void reportError(Spannable spannable,
« dart/pkg/compiler/lib/src/resolution/signatures.dart ('K') | « dart/pkg/compiler/lib/src/resolution/signatures.dart ('k') | dart/pkg/compiler/lib/src/string_validator.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698