Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: dart/pkg/compiler/lib/src/resolution/signatures.dart

Issue 791263003: Remove Compiler.reportFatalError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: One more crash revealed. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/pkg/compiler/lib/src/resolution/signatures.dart
diff --git a/dart/pkg/compiler/lib/src/resolution/signatures.dart b/dart/pkg/compiler/lib/src/resolution/signatures.dart
index 8b31d43489f7aae62ec4bf744aca4e6e21a45c7e..057852e946f97e38dfea8c66f772ea644f2d25e5 100644
--- a/dart/pkg/compiler/lib/src/resolution/signatures.dart
+++ b/dart/pkg/compiler/lib/src/resolution/signatures.dart
@@ -178,6 +178,7 @@ class SignatureResolver extends MappingVisitor<FormalElementX> {
} else if (!identical(enclosingElement.kind,
ElementKind.GENERATIVE_CONSTRUCTOR)) {
error(node, MessageKind.INITIALIZING_FORMAL_NOT_ALLOWED);
+ throw new CompilerCancelledException(null);
Johnni Winther 2015/01/06 08:12:05 Ditto.
ahe 2015/01/07 12:55:24 Done.
} else {
Identifier name = getParameterName(node);
validateName(name);
@@ -186,6 +187,7 @@ class SignatureResolver extends MappingVisitor<FormalElementX> {
if (fieldElement == null ||
!identical(fieldElement.kind, ElementKind.FIELD)) {
error(node, MessageKind.NOT_A_FIELD, {'fieldName': name});
+ throw new CompilerCancelledException(null);
Johnni Winther 2015/01/06 08:12:05 Ditto.
ahe 2015/01/07 12:55:24 Done.
} else if (!fieldElement.isInstanceMember) {
error(node, MessageKind.NOT_INSTANCE_FIELD, {'fieldName': name});
}

Powered by Google App Engine
This is Rietveld 408576698