Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h

Issue 79123004: Implemented failIfMajorPerformanceCaveat WebGL context creation attribute. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Feedback Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
diff --git a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
index a8af08a8811dcad20a6c49dae2e505110fd46aef..3b3f44698966c5d2d83d81e00948956d72584bce 100644
--- a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
+++ b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
@@ -648,6 +648,8 @@ class WebGraphicsContext3DCommandBufferImpl
// the 16-bit range are the same as used by EGL. Those outside the 16-bit
// range are unique to Chromium. Attributes are matched using a closest fit
// algorithm.
+ // To ensure attributes are read by the GPU process changes to this
+ // enum should also be copied to gpu/command_buffer/common/gles2_cmd_utils.cc.
enum Attribute {
ALPHA_SIZE = 0x3021,
BLUE_SIZE = 0x3022,
@@ -661,7 +663,8 @@ class WebGraphicsContext3DCommandBufferImpl
WIDTH = 0x3057,
NONE = 0x3038, // Attrib list = terminator
SHARE_RESOURCES = 0x10000,
- BIND_GENERATES_RESOURCES = 0x10001
+ BIND_GENERATES_RESOURCES = 0x10001,
+ FAIL_IF_MAJOR_PERF_CAVEAT = 0x10002
};
friend class WebGraphicsContext3DErrorMessageCallback;

Powered by Google App Engine
This is Rietveld 408576698