Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5183)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

Issue 79103002: Abstracted AcceptPasswordAutofillSuggestion IPC out of core Autofill code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc b/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc
index 45724c17ba1329857fcf05480f372fc9902536e5..4a4163392ba176e5a9b5914c3266dc2f56057937 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc
+++ b/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc
@@ -35,10 +35,9 @@ namespace {
class MockAutofillExternalDelegate : public AutofillExternalDelegate {
public:
- MockAutofillExternalDelegate(content::WebContents* web_contents,
- AutofillManager* autofill_manager,
+ MockAutofillExternalDelegate(AutofillManager* autofill_manager,
AutofillDriver* autofill_driver)
- : AutofillExternalDelegate(web_contents, autofill_manager,
+ : AutofillExternalDelegate(autofill_manager,
autofill_driver) {}
Ilya Sherman 2013/11/22 00:26:29 nit: Looks like this can fit on the previous line.
jif-google 2013/11/22 12:21:44 Done.
virtual ~MockAutofillExternalDelegate() {}
@@ -141,7 +140,6 @@ class AutofillPopupControllerUnitTest : public ChromeRenderViewHostTestHarness {
AutofillDriverImpl::FromWebContents(web_contents());
external_delegate_.reset(
new NiceMock<MockAutofillExternalDelegate>(
- web_contents(),
driver->autofill_manager(),
driver));
@@ -431,8 +429,7 @@ TEST_F(AutofillPopupControllerUnitTest, PopupsWithOnlyDataLists) {
TEST_F(AutofillPopupControllerUnitTest, GetOrCreate) {
AutofillDriverImpl* driver =
AutofillDriverImpl::FromWebContents(web_contents());
- MockAutofillExternalDelegate delegate(
- web_contents(), driver->autofill_manager(), driver);
+ MockAutofillExternalDelegate delegate(driver->autofill_manager(), driver);
WeakPtr<AutofillPopupControllerImpl> controller =
AutofillPopupControllerImpl::GetOrCreate(
@@ -594,7 +591,7 @@ TEST_F(AutofillPopupControllerUnitTest, GrowPopupInSpace) {
AutofillDriverImpl* driver =
AutofillDriverImpl::FromWebContents(web_contents());
NiceMock<MockAutofillExternalDelegate> external_delegate(
- web_contents(), driver->autofill_manager(), driver);
+ driver->autofill_manager(), driver);
TestAutofillPopupController* autofill_popup_controller =
new TestAutofillPopupController(external_delegate.GetWeakPtr(),
element_bounds[i]);

Powered by Google App Engine
This is Rietveld 408576698