components/autofill/content/renderer/password_autofill_agent.cc - Issue 79103002: Abstracted AcceptPasswordAutofillSuggestion IPC out of core Autofill code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 79103002: Abstracted AcceptPasswordAutofillSuggestion IPC out of core Autofill code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc ('K') | « components/autofill/content/renderer/password_autofill_agent.h ('k') | components/autofill/core/browser/autocomplete_history_manager_unittest.cc » ('j') | components/autofill/core/browser/password_autofill_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_autofill_agent.cc

diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc

index 279175246a83f3212d82a9571eb689e31adefc04..532c57375ca65f1b4a1d58ed6c490dd7b2f2c4ed 100644

--- a/components/autofill/content/renderer/password_autofill_agent.cc

+++ b/components/autofill/content/renderer/password_autofill_agent.cc

@@ -290,7 +290,7 @@ bool PasswordAutofillAgent::TextFieldHandlingKeyDown(

bool PasswordAutofillAgent::DidAcceptAutofillSuggestion(

const blink::WebNode& node,

- const blink::WebString& value) {

+ const blink::WebString& username) {

blink::WebInputElement input;

PasswordInfo password;

if (!FindLoginInfo(node, &input, &password))

@@ -298,7 +298,7 @@ bool PasswordAutofillAgent::DidAcceptAutofillSuggestion(

// Set the incoming |value| in the text field and |FillUserNameAndPassword|

blundell 2013/11/21 17:08:45 username

jif-google 2013/11/22 12:21:44 Done.

// will do the rest.

- input.setValue(value, true);

+ input.setValue(username, true);

return FillUserNameAndPassword(&input, &password.password_field,

password.fill_data,

true /* exact_username_match */,