Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: components/autofill/core/browser/autofill_driver.h

Issue 79103002: Abstracted AcceptPasswordAutofillSuggestion IPC out of core Autofill code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_driver.h
diff --git a/components/autofill/core/browser/autofill_driver.h b/components/autofill/core/browser/autofill_driver.h
index 2d6cc64e5cacd07e90a89e3a84cdf677d288bad2..7db3d357c425fb9513a0aabaf032ef7d59443fc2 100644
--- a/components/autofill/core/browser/autofill_driver.h
+++ b/components/autofill/core/browser/autofill_driver.h
@@ -78,6 +78,10 @@ class AutofillDriver {
virtual void RendererShouldAcceptDataListSuggestion(
const base::string16& value) = 0;
+ // Tells the renderer to accept password autofill suggestion for |value|.
blundell 2013/11/20 20:32:43 the password autofill suggestion
Ilya Sherman 2013/11/21 10:31:56 nit: Might be helpful to rename |value| to somethi
jif-google 2013/11/21 16:46:02 Done.
jif-google 2013/11/21 16:46:02 Renamed |value| to |username| in several methods (
+ virtual void RendererShouldAcceptPasswordAutofillSuggestion(
+ const base::string16& value) = 0;
+
// Tells the renderer to clear the currently filled Autofill results.
virtual void RendererShouldClearFilledForm() = 0;

Powered by Google App Engine
This is Rietveld 408576698