Abstracted AcceptPasswordAutofillSuggestion IPC out of core Autofill code.

components/autofill/core/browser/autofill_driver.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_DRIVER_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_DRIVER_H_
 
 #include <vector>
 
 #include "components/autofill/core/common/form_data.h"
@@ skipping 60 matching lines @@
   // Sends the field type predictions specified in |forms| to the renderer. This
   // method is a no-op if the renderer is not available or the appropriate
   // command-line flag is not set.
   virtual void SendAutofillTypePredictionsToRenderer(
       const std::vector<FormStructure*>& forms) = 0;
 
   // Tells the renderer to accept data list suggestions for |value|.
   virtual void RendererShouldAcceptDataListSuggestion(
       const base::string16& value) = 0;
 
+  // Tells the renderer to accept password autofill suggestion for |value|.

[blundell, 2013/11/20 20:32:43]

the password autofill suggestion

[Ilya Sherman, 2013/11/21 10:31:56]

nit: Might be helpful to rename |value| to something with more semantic context.
 If I'm remembering correctly, the value is a username, so perhaps we should
name the variable |username|?

[jif-google, 2013/11/21 16:46:02]

Done.

[jif-google, 2013/11/21 16:46:02]

Renamed |value| to |username| in several methods (
*AutofillDriver*::RendererShouldAcceptPasswordAutofillSuggestion,
PasswordAutofillAgent::DidAcceptAutofillSuggestion, and
PasswordAutofillManager::DidAcceptAutofillSuggestion ).

+  virtual void RendererShouldAcceptPasswordAutofillSuggestion(
+      const base::string16& value) = 0;
+
   // Tells the renderer to clear the currently filled Autofill results.
   virtual void RendererShouldClearFilledForm() = 0;
 
   // Tells the renderer to clear the currently previewed Autofill results.
   virtual void RendererShouldClearPreviewedForm() = 0;
 
   // Tells the renderer to set the node text.
   virtual void RendererShouldSetNodeText(const base::string16& value) = 0;
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_DRIVER_H_