base/base.gypi - Issue 790903003: Generalizing conditional compilation logic for systems with native utf8 locale.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/base.gypi

Issue 790903003: Generalizing conditional compilation logic for systems with native utf8 locale. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated BUILD.gn based on rvargas comments. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/base.gypi

diff --git a/base/base.gypi b/base/base.gypi

index f9451662c086f77c3be269eeab051684bb344579..7d155fd81e2f5f7e776a27078ebe6c5ecd45de38 100644

--- a/base/base.gypi

+++ b/base/base.gypi

@@ -979,6 +979,11 @@

['OS == "win" and >(nacl_untrusted_build)==1', {

'sources/': [ ['exclude', '\\.h$'] ],

}],

+ # Enable more direct string conversions on platforms with native utf8

+ # strings

+ ['OS=="mac" or OS=="ios" or <(chromeos)==1 or <(chromecast)==1', {

+ 'defines': ['SYSTEM_NATIVE_UTF8'],

+ }],

}],

['base_i18n_target==1', {

« no previous file with comments | « base/BUILD.gn ('k') | base/files/file_path.cc » ('j') | no next file with comments »