base/BUILD.gn - Issue 790903003: Generalizing conditional compilation logic for systems with native utf8 locale.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/BUILD.gn

Issue 790903003: Generalizing conditional compilation logic for systems with native utf8 locale. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated BUILD.gn based on rvargas comments. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/BUILD.gn

diff --git a/base/BUILD.gn b/base/BUILD.gn

index fe03aac66be0bd10bbc0c172a98f1b79b72830c1..a7bd9a2722c8890b18783336331437027f9b2771 100644

--- a/base/BUILD.gn

+++ b/base/BUILD.gn

@@ -771,6 +771,12 @@ component("base") {

"//third_party/modp_b64",

]

+ # Allow more direct string conversions on platforms with native utf8

+ # strings

+ if (is_mac || is_ios || is_chromeos) {

+ defines += [ "SYSTEM_NATIVE_UTF8" ]

+ }

if (is_android) {

sources += [

"memory/discardable_memory_ashmem_allocator.cc",

« no previous file with comments | « no previous file | base/base.gypi » ('j') | no next file with comments »