Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Unified Diff: base/BUILD.gn

Issue 790903003: Generalizing conditional compilation logic for systems with native utf8 locale. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing review comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/base.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index fe03aac66be0bd10bbc0c172a98f1b79b72830c1..e5c270b0bc4c9c219b6daeab5654f7cf39b8ce99 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -936,6 +936,12 @@ component("base") {
]
}
+ # Enable more direct string conversions on platforms with native utf8
rvargas (doing something else) 2014/12/11 22:19:37 nit: s/enable/allow
+ # strings
+ if (is_mac || is_ios || is_chromeos) {
rvargas (doing something else) 2014/12/11 22:19:37 Maybe move this block closer to line 764
+ defines += [ "SYSTEM_NATIVE_UTF8" ]
+ }
+
configs += [ "//build/config/compiler:wexit_time_destructors" ]
if (is_android && !is_debug) {
configs -= [ "//build/config/compiler:optimize" ]
« no previous file with comments | « no previous file | base/base.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698