Generalizing conditional compilation logic for systems with native utf8 locale.

base/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ui.gni")
 
 if (is_android) {
   import("//build/config/android/rules.gni")
 }
 
@@ skipping 918 matching lines @@
     }
   }
 
   if (!use_glib) {
     sources -= [
       "message_loop/message_pump_glib.cc",
       "message_loop/message_pump_glib.h",
     ]
   }
 
+  # Enable more direct string conversions on platforms with native utf8

[rvargas (doing something else), 2014/12/11 22:19:37]

nit: s/enable/allow

+  # strings
+  if (is_mac || is_ios || is_chromeos) {

[rvargas (doing something else), 2014/12/11 22:19:37]

Maybe move this block closer to line 764

+    defines += [ "SYSTEM_NATIVE_UTF8" ]
+  }
+
   configs += [ "//build/config/compiler:wexit_time_destructors" ]
   if (is_android && !is_debug) {
     configs -= [ "//build/config/compiler:optimize" ]
     configs += [ "//build/config/compiler:optimize_max" ]
   }
 }
 
 # This is the subset of files from base that should not be used with a dynamic
 # library. Note that this library cannot depend on base because base depends on
 # base_static.
@@ skipping 568 matching lines @@
   # GYP: //base.gyp:base_unittests_apk
   unittest_apk("base_unittests_apk") {
     deps = [
       ":base_java",
       ":base_java_unittest_support",
       ":base_unittests",
     ]
     unittests_dep = ":base_unittests"
   }
 }