Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 790643009: Revert of Fix layer hoisting image filter corner cases (Closed)

Created:
6 years ago by robertphillips
Modified:
6 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fix layer hoisting image filter corner cases (patchset #3 id:40001 of https://codereview.chromium.org/803183003/) Reason for revert: Breaking DM Original issue's description: > Fix layer hoisting image filter corner cases > > This CL fixes 5 bugs related to hoisting image filters: > > For image filters the src layer (the one prior to filtering) often needs to be > smaller then the final layer. This requires the saveLayer's optional bounds > to be stored (in SkLayerInfo.h and SkRecordDraw.cpp) and then used in > compute_source_rect and carried around in GrCachedLayer. > > The image filters can add an extra offset to the final draw operation. > This is now computed in GrLayerHoister::FilterLayer and carried around in > GrCachedLayer. > > Filtered layers must use exact matches. This is now done in GrLayerCache::lock. > > The filter cache requires a valid matrix so it can compute the correct offset. > This is now done in GrLayerHoister::FilterLayer. > > Filtered layers need to be drawn with drawSprite while unfiltered (and therefore > hopefully atlased) layers can be drawn with drawBitmap. This is now done in > draw_replacement_bitmap. > > Committed: https://skia.googlesource.com/skia/+/702eb9622102599d94ab6798e6227cf29f48c2d3 TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/86f032832fc3527ab561bcbd9d2a546f7f676f73

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -185 lines) Patch
M gm/gmmain.cpp View 7 chunks +14 lines, -20 lines 0 comments Download
M src/core/SkLayerInfo.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 4 chunks +5 lines, -10 lines 0 comments Download
M src/gpu/GrLayerCache.h View 7 chunks +8 lines, -25 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 4 chunks +5 lines, -16 lines 0 comments Download
M src/gpu/GrLayerHoister.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrLayerHoister.cpp View 8 chunks +39 lines, -91 lines 0 comments Download
M src/gpu/GrRecordReplaceDraw.cpp View 2 chunks +6 lines, -16 lines 0 comments Download
M tests/GpuLayerCacheTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/RecordReplaceDrawTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
robertphillips
Created Revert of Fix layer hoisting image filter corner cases
6 years ago (2014-12-16 15:41:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790643009/1
6 years ago (2014-12-16 15:41:30 UTC) #2
commit-bot: I haz the power
6 years ago (2014-12-16 15:41:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/86f032832fc3527ab561bcbd9d2a546f7f676f73

Powered by Google App Engine
This is Rietveld 408576698