Issue 79063004: Fix animation of points attribute for polygons

Issue 79063004: Fix animation of points attribute for polygons (Closed)

Created:
7 years, 1 month ago by pdr.

Modified:
7 years, 1 month ago

Reviewers:
Stephen Chennney, f(malita), fmalita_google_do_not_use, eseidel

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, zoltan1, eae+blinkwatch, leviw+renderwatch, dstockwell, Timothy Loh, krit, f(malita), jchaffraix+rendering, darktears, pdr, bemjb+rendering_chromium.org, Stephen Chennney, Steve Block, dino_apple.com, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix animation of points attribute for polygons This is a merge of http://trac.webkit.org/changeset/159559 by Antoine Quint <graouts@apple.com>;. This patch switches to using the animated points value instead of the non-animated points value in SVGPathData, fixing a bug where points could not be animated. BUG=321710 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162399

Patch Set 1 #

Patch Set 2 : Properly merge #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -2 lines)			Patch
A	LayoutTests/svg/animations/polygon-set.svg	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/animations/polygon-set-expected.svg	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/animations/polyline-set.svg	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/animations/polyline-set-expected.svg	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/rendering/svg/SVGPathData.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/79063004/40001

7 years, 1 month ago (2013-11-20 19:36:27 UTC) #4

eseidel

This new test is super-flake. Please remove. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&showAllRuns=true&tests=fast%2Fjs%2Fglobal-constructors.html%2Cfast%2Fpreloader%2Fdocument-write-noscript.html%2Csvg%2Fanimations%2Fpolygon-set.svg%2Cwebaudio%2Foscillator-sine.html

7 years, 1 month ago (2013-11-21 16:34:17 UTC) #6

pdr.

7 years, 1 month ago (2013-11-21 18:51:08 UTC) #7

Message was sent while issue was closed.

On 2013/11/21 16:34:17, eseidel wrote:
> This new test is super-flake.  Please remove.
> 
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%25...

Thanks for the heads up.

This whole patch was a mistake. Rolling out

Expand Messages | Collapse Messages