DescriptionRevert of Cleaning up MruWindowTracker::BuildWindowList() (patchset #1 id:1 of https://codereview.chromium.org/786513003/)
Reason for revert:
I don't see why this would cause any problems, it looks like a purely aesthetic, yet this is the only Ash related CL in the regression range [1] for ever-failing Win8 Aura [2] and Win7(dbg) ash_unittests since these commits.
(the test failures seem to be timing out with no output, weird... I'll check this back in if the revert doesn't help...)
[1] https://chromium.googlesource.com/chromium/src/+log/8e72e1d6c13fa6a4cf2859ac6e209be4546bb50d..00df169a990ea09d488f1c13ec0293fc11d7992e?pretty=fuller
[2]http://build.chromium.org/p/chromium.win/builders/Win8%20Aura
Failing tests:
ToggleMinimized
WindowDockLeftMinimizeWindowWithRestore
WindowPanelDockLeftDockRightRestore
WindowSnapLeftDockLeftRestore
WindowSnapLeftDockLeftSnapRight
WindowSnapRightDockRightRestore
EventsDoNotLeakToWindowUnderneath
Basic
MinimizedWindowsAreLru
GestureSwipe
SwipeUpDownWithoutReleasing
VerticalSwipes
PanelsHideAndRestoreWithShelf
AcceleratorsWithFullscreen
WorkAreaChangeWorkspace
AlwaysOnTopMultiWindow
AlwaysOnTopWindow
CycleMruPanelDestroyed
CyclePanels
CyclePanelsDestroyed
HandleCycleWindow
MaximizedWindow
MostRecentlyUsed
SelectingHidesAppList
SecondMaximizedWindowHasProperRestoreSize
ActivationCancelsOveriew
Basic
BasicGesture
BasicTabKeyNavigation
BasicTextFiltering
CloseButton
CloseButtonOnPanels
CreateLabelUnderPanel
FullscreenWindow
FullscreenWindowMaximizeMode
LastWindowDestroyed
NewWindowCancelsOveriew
NoCrashWithDesktopTap
NonActivatableWindowsHidden
SelectWindowWithReturnKey
SelectingHidesAppList
Shutdown
TextFilteringSelection
WindowOverviewHidesCalloutWidgets
AnimatedNormToMaxToNormRepositionsRemaining
AutoPlacingMovesTransientChild
BasicAutoPlacingOnShowHide
NormToMaxToMinRepositionsRemaining
NormToMaxToNormRepositionsRemaining
ShelfStateUpdated
TestSingleWindowsRestoredBounds
TestUserHandledWindowRestore
TestUserMovedWindowRepositioning
ToMinimizeRepositionsRemaining
Original issue's description:
> Cleaning up MruWindowTracker::BuildWindowList()
>
> Removing the top_most_at_end parameter which was always set to false and
> was never used.
>
> R=oshima@chromium.org
> BUG=None
>
> Committed: https://crrev.com/f3848eee6c17acc74543c803bcea7ea542e13cbc
> Cr-Commit-Position: refs/heads/master@{#307135}
TBR=oshima@chromium.org,afakhry@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None
Committed: https://crrev.com/595091ca57a47b14110d33ff0a3cf5e1c0bed289
Cr-Commit-Position: refs/heads/master@{#307248}
Patch Set 1 #
Created: 6 years ago
(Patch set is too large to download)
Messages
Total messages: 5 (0 generated)
|