Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 790503003: Revert of Cleaning up MruWindowTracker::BuildWindowList() (Closed)

Created:
6 years ago by gab
Modified:
6 years ago
Reviewers:
afakhry, oshima
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Cleaning up MruWindowTracker::BuildWindowList() (patchset #1 id:1 of https://codereview.chromium.org/786513003/) Reason for revert: I don't see why this would cause any problems, it looks like a purely aesthetic, yet this is the only Ash related CL in the regression range [1] for ever-failing Win8 Aura [2] and Win7(dbg) ash_unittests since these commits. (the test failures seem to be timing out with no output, weird... I'll check this back in if the revert doesn't help...) [1] https://chromium.googlesource.com/chromium/src/+log/8e72e1d6c13fa6a4cf2859ac6e209be4546bb50d..00df169a990ea09d488f1c13ec0293fc11d7992e?pretty=fuller [2]http://build.chromium.org/p/chromium.win/builders/Win8%20Aura Failing tests: ToggleMinimized WindowDockLeftMinimizeWindowWithRestore WindowPanelDockLeftDockRightRestore WindowSnapLeftDockLeftRestore WindowSnapLeftDockLeftSnapRight WindowSnapRightDockRightRestore EventsDoNotLeakToWindowUnderneath Basic MinimizedWindowsAreLru GestureSwipe SwipeUpDownWithoutReleasing VerticalSwipes PanelsHideAndRestoreWithShelf AcceleratorsWithFullscreen WorkAreaChangeWorkspace AlwaysOnTopMultiWindow AlwaysOnTopWindow CycleMruPanelDestroyed CyclePanels CyclePanelsDestroyed HandleCycleWindow MaximizedWindow MostRecentlyUsed SelectingHidesAppList SecondMaximizedWindowHasProperRestoreSize ActivationCancelsOveriew Basic BasicGesture BasicTabKeyNavigation BasicTextFiltering CloseButton CloseButtonOnPanels CreateLabelUnderPanel FullscreenWindow FullscreenWindowMaximizeMode LastWindowDestroyed NewWindowCancelsOveriew NoCrashWithDesktopTap NonActivatableWindowsHidden SelectWindowWithReturnKey SelectingHidesAppList Shutdown TextFilteringSelection WindowOverviewHidesCalloutWidgets AnimatedNormToMaxToNormRepositionsRemaining AutoPlacingMovesTransientChild BasicAutoPlacingOnShowHide NormToMaxToMinRepositionsRemaining NormToMaxToNormRepositionsRemaining ShelfStateUpdated TestSingleWindowsRestoredBounds TestUserHandledWindowRestore TestUserMovedWindowRepositioning ToMinimizeRepositionsRemaining Original issue's description: > Cleaning up MruWindowTracker::BuildWindowList() > > Removing the top_most_at_end parameter which was always set to false and > was never used. > > R=oshima@chromium.org > BUG=None > > Committed: https://crrev.com/f3848eee6c17acc74543c803bcea7ea542e13cbc > Cr-Commit-Position: refs/heads/master@{#307135} TBR=oshima@chromium.org,afakhry@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/595091ca57a47b14110d33ff0a3cf5e1c0bed289 Cr-Commit-Position: refs/heads/master@{#307248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -21 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/focus_cycler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M ash/wm/mru_window_tracker.h View 1 chunk +4 lines, -3 lines 0 comments Download
M ash/wm/mru_window_tracker.cc View 3 chunks +15 lines, -8 lines 0 comments Download
M ash/wm/window_positioner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
gab
Created Revert of Cleaning up MruWindowTracker::BuildWindowList()
6 years ago (2014-12-08 15:03:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790503003/1
6 years ago (2014-12-08 15:03:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-08 15:04:47 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/595091ca57a47b14110d33ff0a3cf5e1c0bed289 Cr-Commit-Position: refs/heads/master@{#307248}
6 years ago (2014-12-08 15:06:13 UTC) #4
gab
6 years ago (2014-12-08 17:56:43 UTC) #5
Message was sent while issue was closed.
Seems like this was indeed the culprit: http://crbug.com/439961

Powered by Google App Engine
This is Rietveld 408576698