Fix 10573: Dismissing FindInPage doesn't set focus to the link...

Fix 10573: Dismissing Find-in page doesn't set focus
to the link found.

We no longer use the selection controller to
highlight the active match. Before this change,
the focus would not be set if the user had changed
the selection. After this change, the focus will
be set unless the user has selected something on
the page.

I also wrote an in-browser unit test for this to
catch this regression in the future, but it is
disabled due to problem with running multiple
in-process browser tests in a row (teardown
problem).

BUG=10573
TEST=Covered by in process browser test now, see
bug for repro steps.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13945

[jcampan, 2009-04-17 16:45:31]

LGTM

http://codereview.chromium.org/79024/diff/1/3
File chrome/test/ui_test_utils.h (right):

http://codereview.chromium.org/79024/diff/1/3#newcode44
Line 44: class JavaScriptRunner : public NotificationObserver {
Nit: a comment on how to use that class would be useful.