Fix 10573: Dismissing FindInPage doesn't set focus to the link...

chrome/browser/views/find_bar_win_unittest.cc

-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/find_notification_details.h"
 #include "chrome/browser/renderer_host/render_view_host.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/browser/tab_contents/web_contents.h"
 #include "chrome/browser/tab_contents/web_contents_view.h"
 #include "chrome/browser/views/find_bar_win.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/test/in_process_browser_test.h"
 #include "chrome/test/ui_test_utils.h"
 
 const std::wstring kFramePage = L"files/find_in_page/frames.html";
 const std::wstring kFrameData = L"files/find_in_page/framedata_general.html";
 const std::wstring kUserSelectPage = L"files/find_in_page/user-select.html";
 const std::wstring kCrashPage = L"files/find_in_page/crash_1341577.html";
 const std::wstring kTooFewMatchesPage = L"files/find_in_page/bug_1155639.html";
+const std::wstring kEndState = L"files/find_in_page/end_state.html";
 
 class FindInPageNotificationObserver : public NotificationObserver {
  public:
   explicit FindInPageNotificationObserver(TabContents* parent_tab)
       : parent_tab_(parent_tab),
         active_match_ordinal_(-1),
         number_of_matches_(0) {
     registrar_.Add(this, NotificationType::FIND_RESULT_AVAILABLE,
         Source<TabContents>(parent_tab_));
     ui_test_utils::RunMessageLoop();
@@ skipping 39 matching lines @@
   // We will at some point (before final update) be notified of the ordinal and
   // we need to preserve it so we can send it later.
   int active_match_ordinal_;
   int number_of_matches_;
 };
 
 typedef enum FindInPageDirection { BACK = 0, FWD = 1 };
 typedef enum FindInPageCase { IGNORE_CASE = 0, CASE_SENSITIVE = 1 };
 
 class FindInPageControllerTest : public InProcessBrowserTest {
+ public:
+  FindInPageControllerTest() {
+    EnableDOMAutomation();
+  }
+
  protected:
   int FindInPage(const std::wstring& search_string,
                  FindInPageDirection forward,
                  FindInPageCase match_case,
                  bool find_next) {
     WebContents* web_contents =
         browser()->GetSelectedTabContents()->AsWebContents();
     if (web_contents) {
       web_contents->set_current_find_request_id(
           FindInPageNotificationObserver::kFindInPageRequestId);
       web_contents->render_view_host()->StartFinding(
           FindInPageNotificationObserver::kFindInPageRequestId,
           search_string, forward == FWD, match_case == CASE_SENSITIVE,
           find_next);
       return FindInPageNotificationObserver(web_contents).number_of_matches();
     }
     return 0;
   }
 };
 
-// This test loads a page with frames and starts FindInPage requests
+// This test loads a page with frames and starts FindInPage requests.
 IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FindInPageFrames) {
   HTTPTestServer* server = StartHTTPServer();
 
   // First we navigate to our frames page.
   GURL url = server->TestServerPageW(kFramePage);
   ui_test_utils::NavigateToURL(browser(), url);
 
   // Try incremental search (mimicking user typing in).
   EXPECT_EQ(18, FindInPage(L"g",       FWD, IGNORE_CASE, false));
   EXPECT_EQ(11, FindInPage(L"go",      FWD, IGNORE_CASE, false));
@@ skipping 22 matching lines @@
   EXPECT_EQ(0, FindInPage(L"CAT", FWD, CASE_SENSITIVE, false));
 
   // Try again case sensitive, but this time with right case.
   EXPECT_EQ(1, FindInPage(L"dog", FWD, CASE_SENSITIVE, false));
 
   // Try non-Latin characters ('Hreggvidur' with 'eth' for 'd' in left frame).
   EXPECT_EQ(1, FindInPage(L"Hreggvi\u00F0ur", FWD, IGNORE_CASE, false));
   EXPECT_EQ(1, FindInPage(L"Hreggvi\u00F0ur", FWD, CASE_SENSITIVE, false));
   EXPECT_EQ(0, FindInPage(L"hreggvi\u00F0ur", FWD, CASE_SENSITIVE, false));
 }
+
+std::string FocusedOnPage(WebContents* web_contents) {
+  ui_test_utils::JavaScriptRunner js_runner(
+      web_contents,
+      L"",
+      L"window.domAutomationController.send(getFocusedElement());");
+  return js_runner.Run();
+}
+
+// This tests the FindInPage end-state, in other words: what is focused when you
+// close the Find box (ie. if you find within a link the link should be
+// focused).
+// TODO(jcampan): This test needs to be enabled once Jay fixes the issues with
+// running two InProc browser tests that both start a web server (crashes).
+IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, DISABLED_FindInPageEndState) {
+  HTTPTestServer* server = StartHTTPServer();
+
+  // First we navigate to our special focus tracking page.
+  GURL url = server->TestServerPageW(kEndState);
+  ui_test_utils::NavigateToURL(browser(), url);
+
+  WebContents* web_contents =
+      browser()->GetSelectedTabContents()->AsWebContents();
+  ASSERT_TRUE(NULL != web_contents);
+
+  // Verify that nothing has focus.
+  ASSERT_STREQ("{nothing focused}", FocusedOnPage(web_contents).c_str());
+
+  // Search for a text that exists within a link on the page.
+  EXPECT_EQ(1, FindInPage(L"nk", FWD, IGNORE_CASE, false));
+
+  // End the find session, which should set focus to the link.
+  web_contents->StopFinding(false);
+
+  // Verify that the link is focused.
+  EXPECT_STREQ("link1", FocusedOnPage(web_contents).c_str());
+
+  // Search for a text that exists within a link on the page.
+  EXPECT_EQ(1, FindInPage(L"Google", FWD, IGNORE_CASE, false));
+
+  // Move the selection to link 1, after searching.
+  ui_test_utils::JavaScriptRunner js_runner(
+      web_contents,
+      L"",
+      L"window.domAutomationController.send(selectLink1());");
+  js_runner.Run();
+
+  // End the find session.
+  web_contents->StopFinding(false);
+
+  // Verify that link2 is not focused.
+  EXPECT_STREQ("", FocusedOnPage(web_contents).c_str());
+}