Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 790233003: Check that V8 snapshot files exist before including them in the installer. (Closed)

Created:
6 years ago by rmcilroy
Modified:
6 years ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, grt+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check that V8 snapshot files exist before including them in the installer. BUG=441258 Committed: https://crrev.com/acb1e62d00c4bd2b2d55d32d87800b3600ca5d99 Cr-Commit-Position: refs/heads/master@{#308087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/installer/linux/common/installer.include View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rmcilroy
phajdan.jr@: Could you please take a look, thanks.
6 years ago (2014-12-12 13:22:50 UTC) #2
rmcilroy
phajdan.jr@: Could you please take a look, thanks.
6 years ago (2014-12-12 13:22:52 UTC) #3
Paweł Hajdan Jr.
LGTM
6 years ago (2014-12-12 14:22:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790233003/1
6 years ago (2014-12-12 14:40:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 15:19:34 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-12 15:20:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/acb1e62d00c4bd2b2d55d32d87800b3600ca5d99
Cr-Commit-Position: refs/heads/master@{#308087}

Powered by Google App Engine
This is Rietveld 408576698