chrome/installer/linux/common/installer.include - Issue 790233003: Check that V8 snapshot files exist before including them in the installer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/linux/common/installer.include

Issue 790233003: Check that V8 snapshot files exist before including them in the installer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/linux/common/installer.include

diff --git a/chrome/installer/linux/common/installer.include b/chrome/installer/linux/common/installer.include

index 4af55a8119ce309d1c86f55e9075e19527b34685..81bb7465205380488c4bf8c31cdd8604480bf445 100644

--- a/chrome/installer/linux/common/installer.include

+++ b/chrome/installer/linux/common/installer.include

@@ -138,8 +138,10 @@ stage_install_common() {

# V8 snapshot files; only necessary when v8_use_external_startup_data is

# set to 1 in build/common.gypi.

- install -m 644 "${BUILDDIR}/natives_blob.bin" "${STAGEDIR}/${INSTALLDIR}/"

- install -m 644 "${BUILDDIR}/snapshot_blob.bin" "${STAGEDIR}/${INSTALLDIR}/"

+ if [ -f "${BUILDDIR}/natives_blob.bin" ]; then

+ install -m 644 "${BUILDDIR}/natives_blob.bin" "${STAGEDIR}/${INSTALLDIR}/"

+ install -m 644 "${BUILDDIR}/snapshot_blob.bin" "${STAGEDIR}/${INSTALLDIR}/"

+ fi

# sandbox

# Rename sandbox binary with hyphen instead of underscore because that's what

« no previous file with comments | « no previous file | no next file » | no next file with comments »