Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 790213004: Add inlining ranges/intervals to code objects so that we can map a pc to the inlined stack. The map… (Closed)

Created:
6 years ago by srdjan
Modified:
5 years, 11 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add inlining ranges/intervals to code objects so that we can map a pc to the inlined stack. The mapping is not fast, used only for disassembly.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -242 lines) Patch
M runtime/vm/compiler.cc View 1 2 5 chunks +10 lines, -2 lines 0 comments Download
M runtime/vm/disassembler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/vm/disassembler.cc View 1 2 chunks +64 lines, -12 lines 0 comments Download
M runtime/vm/disassembler_arm.cc View 1 2 1 chunk +0 lines, -33 lines 0 comments Download
M runtime/vm/disassembler_arm64.cc View 1 1 chunk +0 lines, -33 lines 0 comments Download
M runtime/vm/disassembler_ia32.cc View 1 1 chunk +0 lines, -36 lines 0 comments Download
M runtime/vm/disassembler_mips.cc View 1 1 chunk +0 lines, -35 lines 0 comments Download
M runtime/vm/disassembler_x64.cc View 1 1 chunk +0 lines, -36 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 3 chunks +13 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 2 5 chunks +113 lines, -38 lines 2 comments Download
M runtime/vm/flow_graph_inliner.h View 1 chunk +12 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 7 chunks +35 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 3 chunks +9 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 chunks +46 lines, -3 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
srdjan
6 years ago (2014-12-17 22:56:12 UTC) #2
Cutch
lgtm with small comment https://codereview.chromium.org/790213004/diff/40001/runtime/vm/flow_graph_compiler.cc File runtime/vm/flow_graph_compiler.cc (right): https://codereview.chromium.org/790213004/diff/40001/runtime/vm/flow_graph_compiler.cc#newcode455 runtime/vm/flow_graph_compiler.cc:455: #endif Also add an ASSERT ...
6 years ago (2014-12-19 18:15:01 UTC) #3
srdjan
6 years ago (2014-12-19 19:58:44 UTC) #4 
Transferred CL to another Mac (Issue created. URL:
https://codereview.chromium.org/817823002
) and committed TBR.

https://codereview.chromium.org/790213004/diff/40001/runtime/vm/flow_graph_co...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/790213004/diff/40001/runtime/vm/flow_graph_co...
runtime/vm/flow_graph_compiler.cc:455: #endif
On 2014/12/19 18:15:01, Cutch wrote:
> Also add an ASSERT that functions match.

Done.

Powered by Google App Engine
This is Rietveld 408576698