Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 790213002: Restructure public side of geometry service. (Closed)

Created:
6 years ago by blundell
Modified:
6 years ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Restructure public side of geometry service. This CL goes from this: //mojo/services/public/cpp/geometry //mojo/services/public/interfaces/geometry to this: //mojo/services/geometry/public/cpp //mojo/services/geometry/public/interfaces This CL also makes the Mojo-side changes required to roll this change into Chromium. TBR=beng Committed: https://chromium.googlesource.com/external/mojo/+/f684109bb1a2cdaa0de6e1d9204dfe20f3c8e9de

Patch Set 1 #

Patch Set 2 : Make changes to roll into Chromium #

Patch Set 3 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -178 lines) Patch
M examples/aura_demo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/bitmap_uploader/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/bitmap_uploader/bitmap_uploader.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/bitmap_uploader/bitmap_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/embedded_app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/ganesh_app/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/ganesh_app/texture_uploader.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/ganesh_app/texture_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/js/cube.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M examples/keyboard/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/nesting_app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/sample_app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/sample_app/gles2_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/sky_compositor_app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/surfaces_app/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M examples/surfaces_app/child.mojom View 1 chunk +1 line, -1 line 0 comments Download
M examples/window_manager/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M examples/window_manager/window_manager.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/geometry/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/geometry/geometry_type_converters.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/input_events/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/surfaces/tests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gpu/gl_texture.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/geometry/public/cpp/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/geometry/public/cpp/geometry_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/geometry/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/geometry/public/interfaces/geometry.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/public/cpp/geometry/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
D mojo/services/public/cpp/geometry/geometry_util.h View 1 chunk +0 lines, -39 lines 0 comments Download
M mojo/services/public/interfaces/accessibility/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/accessibility/accessibility.mojom View 1 chunk +1 line, -1 line 0 comments Download
D mojo/services/public/interfaces/geometry/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D mojo/services/public/interfaces/geometry/geometry.mojom View 1 chunk +0 lines, -39 lines 0 comments Download
M mojo/services/public/interfaces/gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/gpu/gpu.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/input_events/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/input_events/input_events.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/native_viewport/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/native_viewport/native_viewport.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/mojo_services_public.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/surfaces/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/surfaces/public/cpp/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/surfaces/public/cpp/surfaces_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/surfaces/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/surfaces/public/interfaces/quads.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/surfaces/public/interfaces/surfaces.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/public/cpp/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/view_manager/public/cpp/tests/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/view_manager/public/cpp/tests/view_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/public/cpp/view.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/public/interfaces/animations.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/public/interfaces/view_manager.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/window_manager/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/window_manager/public/interfaces/window_manager_internal.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/tools/roll/rev_sdk.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M services/gles2/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/gles2/gpu_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/native_viewport/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/surfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M services/view_manager/test_change_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/compositor/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
blundell
Committed patchset #3 (id:40001) manually as f684109bb1a2cdaa0de6e1d9204dfe20f3c8e9de (presubmit successful).
6 years ago (2014-12-10 16:56:48 UTC) #1
blundell
6 years ago (2014-12-10 16:57:13 UTC) #2
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698