Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 789953002: Fix crashes in ElementsUploadDataStreamTest (Closed)

Created:
6 years ago by haavardm
Modified:
6 years ago
Reviewers:
pauljensen
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix crashes in ElementsUploadDataStreamTest standard lib reports: error: attempt to insert with an iterator range [__first, __last) from this container. When compiling standard lib from gcc 4.9 with C++11, insert cannot take the same vector as both source and destination. BUG=None Committed: https://crrev.com/190d3252e6a748150527da946eda704a6a30894d Cr-Commit-Position: refs/heads/master@{#307699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M net/base/elements_upload_data_stream_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
haavardm
I've updated to ubuntu 14.10 with new libraries, which probably explains why I'm among the ...
6 years ago (2014-12-09 21:27:10 UTC) #2
pauljensen
lgtm
6 years ago (2014-12-10 14:08:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789953002/1
6 years ago (2014-12-10 14:17:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-10 14:59:50 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-10 15:01:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/190d3252e6a748150527da946eda704a6a30894d
Cr-Commit-Position: refs/heads/master@{#307699}

Powered by Google App Engine
This is Rietveld 408576698