Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: net/base/elements_upload_data_stream_unittest.cc

Issue 789953002: Fix crashes in ElementsUploadDataStreamTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/elements_upload_data_stream_unittest.cc
diff --git a/net/base/elements_upload_data_stream_unittest.cc b/net/base/elements_upload_data_stream_unittest.cc
index 1882e9a92247792bcd68a5f7b6e6c0f070fd4f51..e2a431cd79a24d770576b9065fbeaa04b56ee050 100644
--- a/net/base/elements_upload_data_stream_unittest.cc
+++ b/net/base/elements_upload_data_stream_unittest.cc
@@ -669,8 +669,8 @@ TEST_F(ElementsUploadDataStreamTest, InitToReset) {
new ElementsUploadDataStream(element_readers_.Pass(), 0));
std::vector<char> expected_data(kTestData, kTestData + kTestDataSize);
- expected_data.insert(expected_data.end(), expected_data.begin(),
- expected_data.begin() + kTestDataSize);
+ expected_data.insert(expected_data.end(), kTestData,
+ kTestData + kTestDataSize);
// Call Init().
TestCompletionCallback init_callback1;
@@ -728,8 +728,8 @@ TEST_F(ElementsUploadDataStreamTest, InitDuringAsyncInit) {
new ElementsUploadDataStream(element_readers_.Pass(), 0));
std::vector<char> expected_data(kTestData, kTestData + kTestDataSize);
- expected_data.insert(expected_data.end(), expected_data.begin(),
- expected_data.begin() + kTestDataSize);
+ expected_data.insert(expected_data.end(), kTestData,
+ kTestData + kTestDataSize);
// Start Init.
TestCompletionCallback init_callback1;
@@ -777,8 +777,8 @@ TEST_F(ElementsUploadDataStreamTest, InitDuringAsyncRead) {
new ElementsUploadDataStream(element_readers_.Pass(), 0));
std::vector<char> expected_data(kTestData, kTestData + kTestDataSize);
- expected_data.insert(expected_data.end(), expected_data.begin(),
- expected_data.begin() + kTestDataSize);
+ expected_data.insert(expected_data.end(), kTestData,
+ kTestData + kTestDataSize);
// Call Init().
TestCompletionCallback init_callback1;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698