Issue 789793004: Revert of Use SkPaint::getFontBounds() for text bounding boxes in pictures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 789793004: Revert of Use SkPaint::getFontBounds() for text bounding boxes in pictures. (Closed)

Created:
6 years ago by mtklein

Modified:
6 years ago

Reviewers:
mtklein_C, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Use SkPaint::getFontBounds() for text bounding boxes in pictures. (patchset #1 id:1 of https://codereview.chromium.org/805983003/) Reason for revert: Test-Win7-ShuttleA-HD2000-x86-Debug-GDI Original issue's description: > Use SkPaint::getFontBounds() for text bounding boxes in pictures. > > Now that SkTextBlobs have landed, this is a perf no-op, but it at least lets us eliminate a bunch of questionable hacks. > > CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot,Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug-Trybot > > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/02d2b9831579173e783569530ab7bae08de907e9 TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/9a5380dd358a9c559a41beef7cb368cd7f0ca51f

Created: 6 years ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -20 lines)			Patch
	M	src/core/SkRecordDraw.cpp	View		2 chunks	+22 lines, -15 lines	0 comments	Download
	M	tests/RecordDrawTest.cpp	View		1 chunk	+5 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of Use SkPaint::getFontBounds() for text bounding boxes in pictures.

6 years ago (2014-12-16 14:30:11 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789793004/1

6 years ago (2014-12-16 14:30:54 UTC) #2

commit-bot: I haz the power

6 years ago (2014-12-16 14:31:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9a5380dd358a9c559a41beef7cb368cd7f0ca51f