Fix disappearing page actions bug.

chrome/browser/ui/views/location_bar/location_bar_view.h

Index: chrome/browser/ui/views/location_bar/location_bar_view.h
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.h b/chrome/browser/ui/views/location_bar/location_bar_view.h
index c3eff2c908100644ca2ed3ed230781f0d179494c..35e1e8451f12732f6508541c2b8b946cee49e9e0 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.h
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.h
@@ -301,8 +301,8 @@ class LocationBarView : public LocationBar,
   // of at least one of the views in |content_setting_views_| changed.
   bool RefreshContentSettingViews();
 
-  // Deletes all page action views that we have created.
-  void DeletePageActionViews();
+  // Deletes all page actions and page action views that we have created.
+  void DeletePageActionsAndViews();
 
   // Updates the views for the Page Actions, to reflect state changes for
   // PageActions. Returns true if the visibility of a PageActionWithBadgeView
@@ -474,9 +474,13 @@ class LocationBarView : public LocationBar,
   ManagePasswordsIconView* manage_passwords_icon_view_;
 
   // The current page actions.
+  // There should be a 1:1 correspondence between elements of |page_actions_|
+  // and elements of |page_action_views_|.
   PageActions page_actions_;
 
   // The page action icon views.
+  // There should be a 1:1 correspondence between elements of |page_actions_|
+  // and elements of |page_action_views_|.
   PageActionViews page_action_views_;

[danduong, 2014/12/20 03:17:02]

page_action_views_ actually have a ref their corresponding page_action.  I think
we can just drop the page_actions_ altogether.

[erikchen, 2014/12/22 20:39:43]

Yup, done.

 
   // The icon for Translate.